Add toEightFigureString and toTenFigureString #6
Conversation
Update to OSRef.php to add toEightFigureString and toTenFigureString. Allows for 10m and 1m accuracy grid references to be created from easting northing.
Add toEightFigureString and totenFigureString
|
Hi I'm happy (in theory) to take a PR to add these functions, but I'm not a fan of the amount of copy/pasted code this involves - can you turn the existing toSixFigureString into a function that takes a value (6,8,10), and then outputs a string of the relevant length? Then to[Six/Eight/Ten]FigureString could just be wrappers around it. |
|
Excellent idea. I'll have a bash at it tomorrow... Steve |
Added new PRIVATE function 'toGridReference($length)' - private as there is no validation on the $length variable. So can only be called by clild functions. Changed 'toSixFigureReference' to be a wrapper to new function. Added 'toTwoFigureReference', 'toFourFigureReference', 'toEightFigureReference' and 'toTenFigureReference'.
Added additional test to check new 2, 4, 8 and 10 figure grid ref string functions.
Typos...
|
All done @dvdoug - let me know what you think. Steve |
|
Thanks for the patch! I've merged it in, and tagged a new release that includes it (v2.0.1) |
|
Thanks Doug! Thanks for the package. I’ve been using it for a long time - prior to your work to pull it into Git - when it was just on the jstott site. Steve On 19 Jan 2016, at 22:06, Doug Wright <notifications@github.commailto:notifications@github.com> wrote: Thanks for the patch! I've merged it in, and tagged a new release that includes it (v2.0.1) — |
Edited OSRef to add 2 new functions (cloned from toSixFigureRef) that allow 10m (8 figure) resolution and 1m (10 figure) resolution grid references from the easting / northing of OSRef.