Merge pull request #36 from bsyk/patch-1

Set timeout error code to 504
dvonlehman · Sep 6, 2018 · 75d1c3e · 75d1c3e
2 parents e87fc14 + 7b17370
commit 75d1c3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/proxy.js b/lib/proxy.js
@@ -262,7 +262,7 @@ module.exports = function(options) {
   function unhandledApiError(err, next) {
     debug('unhandled API error: %s', err.code);
     if (err.code === 'ETIMEDOUT' || err.code === 'ESOCKETTIMEDOUT') {
-      return next(Error.http(408, 'API call timed out'));
+      return next(Error.http(504, 'API call timed out'));
     }
     return next(err);
   }

diff --git a/test/errors.js b/test/errors.js
@@ -29,13 +29,13 @@ describe('timeout', function() {
       .end(done);
   });
 
-  it('api timeout returns 408', function(done) {
+  it('api timeout returns 504', function(done) {
     this.apiLatency = 50;
     this.proxyOptions.timeout = 20;
 
     supertest(this.server)
       .get('/proxy')
-      .expect(408, done);
+      .expect(504, done);
   });
 
   it('api returns 408 when instructed to cache', function(done) {