New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Exception from interface to a class #5

Merged

Hodgy merged 1 commit into main from feature-BL-12218-implement-authentication-methods

Jun 3, 2021

Contributor

JoshuaLicense commented Jun 3, 2021 •

edited

Loading

This MR:
Will refactor the original exception (interface) to a class.

aws-sdk-php does not use concrete exceptions as far as I can see.
We would have tens of exceptions and crazy logic to try get a "common" exceptions across authentication implementations.
I got a much better way of handling exceptions, that will reduce our work drastically.


          Refactor the exception to a class instead of an interface

b196fc0

JoshuaLicense self-assigned this

JoshuaLicense requested a review from Hodgy

June 3, 2021 08:53

Hodgy approved these changes

View reviewed changes

Hodgy merged commit df36ba7 into main

Hodgy deleted the feature-BL-12218-implement-authentication-methods branch

June 9, 2021 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment