Skip to content

Commit

Permalink
Add regression test (story) for PR #133, update changelog (#135)
Browse files Browse the repository at this point in the history
* Add story for PR #133

* Update changelog for 3.0.3

* Typo fix
  • Loading branch information
srmagura committed Feb 8, 2022
1 parent 6fb13f9 commit 1691d54
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 1 deletion.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## 3.0.3

### Bug Fixes

- Fix an edge case where the animated highlight had the wrong vertical position (#133)

### Thanks!

- @HexM7

## 3.0.2

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-loading-skeleton",
"version": "3.0.2",
"version": "3.0.3",
"description": "Make beautiful, animated loading skeletons that automatically adapt to your app.",
"keywords": [
"react",
Expand Down
17 changes: 17 additions & 0 deletions src/__stories__/Skeleton.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -367,3 +367,20 @@ export const ShadowDOM: React.VFC = () => {
</div>
)
}

export const RegressionTest133 = () => (
<div>
<p>
Regression test for{' '}
<a href="https://github.com/dvtng/react-loading-skeleton/pull/133">#133</a>,
in which the pseudoelement had the wrong vertical position. The animated
highlight should cover the entire square.
</p>
<div style={{ display: 'flex' }}>
<Skeleton
baseColor="paleturquoise"
style={{ display: 'block', width: 200, height: 200 }}
/>
</div>
</div>
)

0 comments on commit 1691d54

Please sign in to comment.