CSRF with setting the buffer back after reading _csrf token #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of this? I got stuck on this rambocoder@62cdb5a#diff-73243618e93c04599ec851219e2e2863R55 because if I did ~ts instead of ~p, then if a CSRF token passed from the client was in UTF8 format, cowboy req blew up on iolist_size(Body). So I decided to stick with ~p |
|
@dvv ping |
|
Oh, sorry for delay. I commented on there. |
Removed use of io_lib
|
I updated with a new commit. Good idea on not exposing CSRF token. I was doing it more for logging and debugging purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.