Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not mess with klipper url, allow access via ssh or sites like gitlab, alternate to #452 #465

Closed
wants to merge 1 commit into from

Conversation

hg42
Copy link

@hg42 hg42 commented May 6, 2024

like #452, which says
"This addresses #398 as well as including the functionality from the open PR #323 regarding ssh cloning (since, they both touch the same line of code, in effectively the same way)"

the git url for klipper can be on other schemes like ssh:// or https://gitlab.

Additionally, if there is a need to use http:// e.g. because of firewall rules etc. then the current code would not allow this, because it removes the http://github.com/ and adds https://github.com/.

Actually, I would just remove the code that messes with the url.

I only inserted the addition of https://github.com/ for compatibility in case the configuration does not contain a full url.

Not sure why the .git was removed but not added afterwards. The official github clone url would have a .git at the end.
Also, in clone_klipper the sed command uses the i-flag, but not in switch_clipper_repo_menu.

Not messing with the url would remove the duplicate code of the same thing.
Alternatively, the url could be normalized in a central function, e.g. normalize_git_url.

@hg42 hg42 changed the title do not mess with klipper url, allow access via ssh or sites like gitlab do not mess with klipper url, allow access via ssh or sites like gitlab, alternate to #452 May 6, 2024
@hg42
Copy link
Author

hg42 commented May 6, 2024

ok, I see the rewrite in python... :-)

@hg42 hg42 closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant