[OmniLink] Fix zone bypass/restore commands (openhab#11005)

* Fix zone bypass/restore commands * Name variables using openHAB guidelines Signed-off-by: Ethan Dye <mrtops03@gmail.com> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 · Jul 25, 2021 · 72ca51e · 72ca51e
1 parent 66252b4
commit 72ca51e
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 22 deletions.
diff --git a/.../src/main/java/org/openhab/binding/omnilink/internal/handler/AbstractOmnilinkHandler.java b/.../src/main/java/org/openhab/binding/omnilink/internal/handler/AbstractOmnilinkHandler.java
@@ -118,6 +118,11 @@ protected int getThingNumber() {
      * @return Configured area number for a thing.
      */
     protected int getAreaNumber() {
-        return ((Number) getThing().getConfiguration().get(THING_PROPERTIES_AREA)).intValue();
+        String areaNumber = getThing().getProperties().get(THING_PROPERTIES_AREA);
+        if (areaNumber != null) {
+            return Integer.valueOf(areaNumber);
+        } else {
+            return -1;
+        }
     }
 }
diff --git a/...ilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioSourceHandler.java b/...ilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioSourceHandler.java
@@ -50,7 +50,7 @@
 @NonNullByDefault
 public class AudioSourceHandler extends AbstractOmnilinkHandler {
     private final Logger logger = LoggerFactory.getLogger(AudioSourceHandler.class);
-    private final int POLL_DELAY_SECONDS = 5;
+    private final int pollDelaySeconds = 5;
     private final int thingID = getThingNumber();
     private @Nullable ScheduledFuture<?> scheduledPolling = null;
     public @Nullable String number;
@@ -104,7 +104,7 @@ private synchronized void cancelPolling() {
     private synchronized void schedulePolling() {
         cancelPolling();
         logger.debug("Scheduling polling for Audio Source: {}", thingID);
-        scheduledPolling = super.scheduler.scheduleWithFixedDelay(this::pollAudioSource, 0, POLL_DELAY_SECONDS,
+        scheduledPolling = super.scheduler.scheduleWithFixedDelay(this::pollAudioSource, 0, pollDelaySeconds,
                 TimeUnit.SECONDS);
     }
 

diff --git a/...ing.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ZoneHandler.java b/...ing.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ZoneHandler.java
@@ -125,7 +125,6 @@ public void handleCommand(ChannelUID channelUID, Command command) {
             default:
                 mode = -1;
         }
-        int areaNumber = getAreaNumber();
         logger.debug("mode {} on zone {} with code {}", mode, thingID, command.toFullString());
         char[] code = command.toFullString().toCharArray();
         if (code.length != 4) {
@@ -134,25 +133,30 @@ public void handleCommand(ChannelUID channelUID, Command command) {
             try {
                 final OmnilinkBridgeHandler bridge = getOmnilinkBridgeHandler();
                 if (bridge != null) {
-                    SecurityCodeValidation codeValidation = bridge.reqSecurityCodeValidation(areaNumber,
-                            Character.getNumericValue(code[0]), Character.getNumericValue(code[1]),
-                            Character.getNumericValue(code[2]), Character.getNumericValue(code[3]));
-                    /*
-                     * 0 Invalid code
-                     * 1 Master
-                     * 2 Manager
-                     * 3 User
-                     */
-                    logger.debug("User code number: {} level: {}", codeValidation.getCodeNumber(),
-                            codeValidation.getAuthorityLevel());
-                    /*
-                     * Valid user code number are 1-99, 251 is duress code, 0 means code does not exist
-                     */
-                    if ((codeValidation.getCodeNumber() > 0 && codeValidation.getCodeNumber() <= 99)
-                            && codeValidation.getAuthorityLevel() > 0) {
-                        sendOmnilinkCommand(mode, codeValidation.getCodeNumber(), thingID);
+                    int areaNumber = getAreaNumber();
+                    if (areaNumber == -1) {
+                        logger.warn("Could not identify area, canceling bypass/restore command!");
                     } else {
-                        logger.warn("System reported an invalid code");
+                        SecurityCodeValidation codeValidation = bridge.reqSecurityCodeValidation(getAreaNumber(),
+                                Character.getNumericValue(code[0]), Character.getNumericValue(code[1]),
+                                Character.getNumericValue(code[2]), Character.getNumericValue(code[3]));
+                        /*
+                         * 0 Invalid code
+                         * 1 Master
+                         * 2 Manager
+                         * 3 User
+                         */
+                        logger.debug("User code number: {} level: {}", codeValidation.getCodeNumber(),
+                                codeValidation.getAuthorityLevel());
+                        /*
+                         * Valid user code number are 1-99, 251 is duress code, 0 means code does not exist
+                         */
+                        if ((codeValidation.getCodeNumber() > 0 && codeValidation.getCodeNumber() <= 99)
+                                && codeValidation.getAuthorityLevel() > 0) {
+                            sendOmnilinkCommand(mode, codeValidation.getCodeNumber(), thingID);
+                        } else {
+                            logger.warn("System reported an invalid code!");
+                        }
                     }
                 } else {
                     logger.debug("Received null bridge while sending zone command!");