This repository has been archived by the owner on May 16, 2019. It is now read-only.
Add some nicolinks! #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koizuka
reviewed
Apr 22, 2017
app/models/nico_link.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| class NicoLink | ||
| NICOLINK_RE = /(?<pre>^|[^\/\)\w])((?<id1>(ap|ar|az|ch|co|dw|im|jps|kn|lv|nc|nw|td)[0-9]+)|(?<id2>sm[0-9]+)(?<time>#[0-9]{1,2}:[0-5][0-9])?)/ |
There was a problem hiding this comment.
id2(動画リンク)は sm の他にも so は少なくとも欲しいかな。厳密には昔のが他にもあるけど。あと lvもむしろ id2かな。時間アンカー付くので
|
これはさすがにテスト欲しくなる |
execjosh
force-pushed
the
feature/nicolinks
branch
2 times, most recently
from
4f60dd1
to
33bbcf8
Compare
|
こんな記事があったのか：http://dic.nicovideo.jp/a/id 時間アンカーはひとまず措いて
既に処理の最後に通っているようだけど、これとは違うものかな？ |
execjosh
commented
Apr 22, 2017
app/models/nico_link.rb
Outdated
| so | ||
| ].freeze | ||
|
|
||
| NICOLINK_RE = %r{(?<prefix>^|[^\/\)\w])(?<nico_id>(#{ALL_TYPES.join('|')})[0-9]+)} |
execjosh
force-pushed
the
feature/nicolinks
branch
from
33bbcf8
to
9ee6c80
Compare
execjosh
commented
Apr 23, 2017
| class NicoLink | ||
| BASE_URI = URI.parse('https://nico.ms') | ||
|
|
||
| TEMPORAL_TYPES = %w[ |
|
squashとrebaseよろー |
取り敢えず次の種類を実装する。 - 分秒可 - lv 生放送 - sm 動画 - so 公式動画 - 分秒無し - im 静画
execjosh
force-pushed
the
feature/nicolinks
branch
from
c75b701
to
5ef59a2
Compare
|
✅ rebase |
|
thx :nicoru: |
execjosh
pushed a commit
to execjosh/mastodon
that referenced
this pull request
May 1, 2017
Add some nicolinks!
acid-chicken
added a commit
to 346design/twista.283.cloud
that referenced
this pull request
Apr 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAQを基に作ったけどあまり詳しくないので、もし間違ったところあれば直します！ご指摘ください！
Issue #3