Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanently hide option #40

Closed
L1cardo opened this issue Dec 18, 2019 · 8 comments
Closed

Add permanently hide option #40

L1cardo opened this issue Dec 18, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@L1cardo
Copy link
Contributor

L1cardo commented Dec 18, 2019

It would be cool if we can permanently hide some icon, and show them with special click.
This could be like Dozer, but I don't like Dozer, so please add this feature and I can uninstall Dozer.

@L1cardo L1cardo changed the title Add permanent hide option Add permanently hide option Dec 18, 2019
@viettrungphan
Copy link
Collaborator

viettrungphan commented Dec 18, 2019

Know how to do this but we want to keep this app as simple as possible, we can add this feature if we find a way to make the simple UI for users can using this without study.

Basically, just add one more bar button item at the right of "|" button, any button want to hide permanently should move to the right-hand side of this button, if enable permanently mode will change button size to very high width, just like the logic of button "|". Add this will make UI has 3 sections and may lead users more confusing.
At the beginning of this project, we add only one button instead of 2 buttons (| and >) but Apple rejects our app because they don't let us use right mouse click on the bar button (the default left mouse click use to toggle show/hide). Finally, we end up with 2 buttons.

@viettrungphan viettrungphan added the enhancement New feature or request label Dec 18, 2019
@L1cardo
Copy link
Contributor Author

L1cardo commented Dec 18, 2019

I am looking forward to it. Permanently hide is really a cool and useful feature.
I think since this is a free software, you can make two builds. one for Apple store , one for local install.

@p-z-l
Copy link
Contributor

p-z-l commented Dec 20, 2019

I'm currently working on that, will propose a PR if this is not making the app too complicated.

@viettrungphan
Copy link
Collaborator

Working on this required very carefully checking, especially in case the user installs the new app, the new app bar icon(s) may add to the very right position of System Bar, this default behavior make the new bar item(s) permanently hide without user notice.

@p-z-l
Copy link
Contributor

p-z-l commented Dec 21, 2019

I'm leaving permanently hide option turned off by default. Users need to enable it manually in the Preferences window. Also, I'm planning to make a help page as a guide to users.

@L1cardo
Copy link
Contributor Author

L1cardo commented Dec 21, 2019

@p-z-l cool! I am looking forward to it!

@p-z-l
Copy link
Contributor

p-z-l commented Dec 21, 2019

Check this out: Pull Request #53

@m-cerveny
Copy link

At the beginning of this project, we add only one button instead of 2 buttons (| and >) but Apple rejects our app because they don't let us use right mouse click on the bar button (the default left mouse click use to toggle show/hide). Finally, we end up with 2 buttons.

This is interesting. If you look at the behaviour of application "Amphetamine" (AppStore version) it allows only one icon and has left/right-click behaviour...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants