Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to pnpm #46

Merged
merged 8 commits into from Apr 19, 2023
Merged

feat: migrate to pnpm #46

merged 8 commits into from Apr 19, 2023

Conversation

toanbku
Copy link
Contributor

@toanbku toanbku commented Apr 4, 2023

What's this PR do?

  • Migrate from yarn to pnpm

What are the relevant Git tickets?

#42

How to test:

  • Install the latest version of pnpm: npm i -g pnpm
  • Clone this branch to your local machine (remember to delete node_modules folder)
  • Try to run all commands declared in package.json

Note:

  • Please note that the CI/CD failed as expected

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

⚠️ No Changeset found

Latest commit: d37a98e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for react-toolkit ready!

Name Link
🔨 Latest commit d37a98e
🔍 Latest deploy log https://app.netlify.com/sites/react-toolkit/deploys/643e55e1f1c9e90008c3fa76
😎 Deploy Preview https://deploy-preview-46--react-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@toanbku toanbku changed the title feat: migrate to pnpm [WIP] feat: migrate to pnpm Apr 4, 2023
@toanbku toanbku changed the title [WIP] feat: migrate to pnpm feat: migrate to pnpm Apr 15, 2023
@zlatanpham
Copy link
Member

zlatanpham commented Apr 16, 2023

@toanbku any idea how can we fix the CI/CD?

@ngolapnguyen
Copy link
Contributor

ngolapnguyen commented Apr 18, 2023

Updates:

  • Fixed CI/CD for Netlify
  • Compressed Size action is failing because we are switching from pnpm to yarn. preactjs/compress-size-action is depending on the base branch to decide the package manager, but it doesn't remove node_modules upon checking out from current branch to base branch (master). This causes the script to fail to install dependencies for the base branch with yarn, because node_modules was original installed with pnpm and it's not compatible with yarn. Check this PR where we have pnpm for both the merge & base branches: test: test #47

@zlatanpham zlatanpham merged commit 9ffbfb4 into master Apr 19, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants