Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONKEY1-FLOPPY-VGA-FR: Fatal duplicate offset error in ScummRp/ScummTr #18

Closed
dwatteau opened this issue Jan 10, 2021 · 0 comments
Closed

MONKEY1-FLOPPY-VGA-FR: Fatal duplicate offset error in ScummRp/ScummTr #18

dwatteau opened this issue Jan 10, 2021 · 0 comments
Assignees
@dwatteau
Labels
bug Something isn't working

Comments

@dwatteau
Copy link
Owner

dwatteau commented Jan 10, 2021 •
edited

ScummRp and ScummTr both fail on MONKEY1-FLOPPY-VGA-FR (not the EGA version, not the CD-ROM version) with the following error:

ERROR: Duplicate offset in index: 0x18E82 in room 59

Original Win32 binaries also have this problem.

RoomPack::_checkDupOffset() in ScummRp/block.cpp has some code to deal with this.
@dwatteau dwatteau added the bug Something isn't working label Jan 10, 2021
@dwatteau dwatteau self-assigned this Jan 10, 2021
dwatteau added a commit that referenced this issue Jan 10, 2021
@dwatteau
fix(scummrp): Fix fatal "Duplicate offset in index" error for MONKEY1…
dc94b2a 
…-FLOPPY-VGA

It appears that this version of Monkey Island has CO_0117 as a duplicate
costume for CO_0010.  This would break ScummRp and ScummTr extraction.

As far as I know, the EGA and the CD-ROM versions of Monkey Island 1
don't have this bug.

Issue #18.
@dwatteau dwatteau mentioned this issue Jan 10, 2021
Merged
@dwatteau dwatteau mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwatteau dwatteau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwatteau