DONTMERGE: fix(scummtr): Work around script bug in 07.LFL in MANIAC-V2-EN #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of MANIAC-V2-EN miss a byte in the opcode sequence for printEgo, causing a fatal error while trying to export the subtitles. See #12.
|
The fact that the game gets corrupted after fixing this opcode is probably caused by #16. |
dwatteau
changed the title
dwatteau
force-pushed
the
main
branch
2 times, most recently
from
c65d87f
to
572a913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of MANIAC-V2-EN miss a byte in the opcode sequence for
printEgo, causing a fatal error while trying to export the subtitles.
See #12.
Here's a cleaner attempt… it's still wrong, because when you import the translation again, the game switches to demo mode in ScummVM.