Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional sampler args keyword-only #1316

Merged

Conversation

arcondello
Copy link
Member

This helps avoid confusing results when switching between samplers.

This is a backwards compatibility break, but a minor one so I think it's safe.

This helps avoid confusing results when switching between samplers.
@codecov-commenter
Copy link

Codecov Report

Merging #1316 (fa6e6d6) into main (d5a3059) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          94       94           
  Lines       10126    10126           
=======================================
  Hits         9285     9285           
  Misses        841      841           
Impacted Files Coverage Δ
dimod/reference/samplers/exact_solver.py 99.02% <100.00%> (ø)
dimod/reference/samplers/identity_sampler.py 88.88% <100.00%> (ø)
dimod/reference/samplers/random_sampler.py 100.00% <100.00%> (ø)
dimod/reference/samplers/simulated_annealing.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arcondello arcondello merged commit 5ef7897 into dwavesystems:main Mar 13, 2023
@arcondello arcondello deleted the feature/keyword-only-sampler-args branch March 13, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants