Refactor for robustness #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
force-pushed
the
refactor-for-robustness
branch
2 times, most recently
from
8823604
to
ee0f089
Compare
randomir
force-pushed
the
refactor-for-robustness
branch
from
7767a09
to
efd68c9
Compare
|
Far from what I plan to do under this banner, but I'll break it up in a few PRs. |
JoelPasvolsky
approved these changes
Nov 10, 2020
arcondello
reviewed
Nov 10, 2020
Use urllib3's retry defaults (10 retries total, across all error conditions). This implements all "easy cases" described in dwavesystems#414.
Contributes to dwavesystems#357.
This is needed because we currently handle both: - parsed values (str/int/float/bool/...) - unparsed string values in the constructor. Ideally, we would move parsing downstream to config submodule.
Due to nonatomicity of solver selection on specialized and base client, the order might differ, so we should consider all solvers, not just the first one.
Try to work around some warts, hopefully can be simplified with SAPI changes.
randomir
force-pushed
the
refactor-for-robustness
branch
from
efd68c9
to
c22dc21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414.
Closes #229.
Partially addresses #412.
Partially addresses #439.
Partially addresses #357.
Helps with #228.