New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add problem labelling support #444
Conversation
`label` kwarg has been added to all `sample_*` methods on all solvers.
We add `computation.Future.label` and `problem_label` to `Future.sampleset.info` dict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm only partway through but as it's approved I'll ask quickly before it's merged, @randomir can you say something about your considerations on explicitly having label in the sampling functions' parameters as you have versus pulling it out of |
@JoelPasvolsky, I went with explicit because Originally, we thought to have label as a solver parameter, but to allow filtering by label, SSW decided to implement it level up, next to problem id, problem type, status, etc. Alternatively, we could repurpose |
Thanks, @randomir, that makes sense. I guess the reason this caught my attention is that I feel it's good to have the minimum number of arguments to sampling functions to make those simple conceptually for users, so every explicit argument should carry its weight, and it's not clear to me that most users will often use labels (they're very useful for examples such as those in dwave-examples and animated demos), but it's another argument they need to learn when they're getting started. |
@JoelPasvolsky, I agree. FWIW, dimod samplers in dwave-system use kwargs, so we don't have to extract label as explicit argument there. Most users (especially new users) interface only with dwave-system samplers anyhow. |
Changes since 0.8.2: New Features --- - All SAPI requests retried whenever possible, controlled with new `http_retry_*` Client options (#414) - Introduced `SAPIError` base exception with SAPI error message and code, other exceptions reorganized in a backwards-compatible way - Support for problem labels: `sample_*` methods accept optional `label` kwarg, and `Future.sampleset.info` contains `problem_label` (#444) - Switched to CircleCI (#119) Fixes --- - Handle remote disconnects in an edge case (#229)
No description provided.