Few minor auth flow security and performance improvements #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
requested review from
charleswhchan,
thisac,
arcondello and
dwave-bnugmanov
arcondello
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
=======================================
Coverage 88.47% 88.48%
=======================================
Files 33 33
Lines 4356 4359 +3
=======================================
+ Hits 3854 3857 +3
Misses 502 502 ☔ View full report in Codecov by Sentry. |
charleswhchan
approved these changes
Feb 28, 2024
dwave-bnugmanov
approved these changes
Feb 28, 2024
thisac
approved these changes
Feb 29, 2024
randomir
deleted the
fix/few-minor-auth-flow-security-and-performance-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the auth flow according to OAuth 2.0 Security Best Current Practice, motivated by #605.