Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Di graph support #205

Merged
merged 16 commits into from Nov 9, 2021
Merged

Di graph support #205

merged 16 commits into from Nov 9, 2021

Conversation

rjcortese
Copy link
Contributor

Hello,
This is for #203.
It picks up where #200 left off.
I think I've made necessary changes except for some finishing the tests... but I could use a review and feedback :)

tests/test_tsp.py Outdated Show resolved Hide resolved
@arcondello
Copy link
Member

Thanks for the PR! A few minor things but overall seems to be going in the right direction

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #205 (96cb92b) into main (cbf0ea5) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   71.15%   71.32%   +0.16%     
==========================================
  Files          29       29              
  Lines        1751     1761      +10     
==========================================
+ Hits         1246     1256      +10     
  Misses        505      505              
Impacted Files Coverage Δ
dwave_networkx/algorithms/tsp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf0ea5...96cb92b. Read the comment docs.

Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is ready to merge?

@rjcortese
Copy link
Contributor Author

Only thing left I guess is some test related stuff... I'm not sure how to test QUBO returned from dnx.traveling_salesperson_qubo(G, missing_edge_weight=1). I made a comment regarding it in the code.
Thoughts?

@rjcortese
Copy link
Contributor Author

This is ready to merge now imo :)

@arcondello arcondello merged commit 34ae89a into dwavesystems:main Nov 9, 2021
@rjcortese rjcortese deleted the DiGraph-Support branch November 9, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants