-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for AppVeyor #158
Conversation
e65e28f
to
adfd163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the PATH fix works here as well.
But I would really, really, like to understand why these are showing:
C:\Python35\lib\site-packages\wheel\bdist_wheel.py:78: RuntimeWarning: Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
warn=(impl == 'cp')):
C:\Python35\lib\site-packages\wheel\bdist_wheel.py:83: RuntimeWarning: Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
sys.version_info < (3, 8)))
AFAICT, it should be harmless. But it would be good to know for sure before we release a new version of Ocean.
Btw, appveyor utility files can now also be removed (see dwavesystems/qbsolv#152).
Is this only on Py3.5? That's in EOL, can we drop it now? |
No, @boothby, it's on all versions. @arcondello, sure, I don't mind dropping 3.5. |
@hhtong, as long as you're fixing appveyor, can you also add tests for py38? |
@randomir Will do that right now. Should I also be removing the tests for 3.5 then? Or wait |
I would wait on 3.5, it's a bigger conversation. |
@hhtong, I would wait with py35. It's not solving anything, and it's not in our way right now. |
No description provided.