Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for AppVeyor #158

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Fix build for AppVeyor #158

merged 3 commits into from
Sep 18, 2020

Conversation

hhtong
Copy link
Contributor

@hhtong hhtong commented Sep 17, 2020

No description provided.

@hhtong hhtong force-pushed the appveyor branch 5 times, most recently from e65e28f to adfd163 Compare September 17, 2020 20:36
Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PATH fix works here as well.

But I would really, really, like to understand why these are showing:

C:\Python35\lib\site-packages\wheel\bdist_wheel.py:78: RuntimeWarning: Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
  warn=(impl == 'cp')):
C:\Python35\lib\site-packages\wheel\bdist_wheel.py:83: RuntimeWarning: Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
  sys.version_info < (3, 8)))

AFAICT, it should be harmless. But it would be good to know for sure before we release a new version of Ocean.

Btw, appveyor utility files can now also be removed (see dwavesystems/qbsolv#152).

@boothby
Copy link
Collaborator

boothby commented Sep 18, 2020

Is this only on Py3.5? That's in EOL, can we drop it now?

@arcondello
Copy link
Member

arcondello commented Sep 18, 2020

@boothby, good point. Should we just be dropping 3.5 in Ocean generally? @randomir

dwavesystems/dwave-ocean-sdk#91

@randomir
Copy link
Member

No, @boothby, it's on all versions.

@arcondello, sure, I don't mind dropping 3.5.

@randomir
Copy link
Member

randomir commented Sep 18, 2020

@hhtong, as long as you're fixing appveyor, can you also add tests for py38?

@hhtong
Copy link
Contributor Author

hhtong commented Sep 18, 2020

@randomir Will do that right now. Should I also be removing the tests for 3.5 then? Or wait

@arcondello
Copy link
Member

I would wait on 3.5, it's a bigger conversation.

@randomir
Copy link
Member

@hhtong, I would wait with py35. It's not solving anything, and it's not in our way right now.

@hhtong hhtong merged commit e8c273a into dwavesystems:main Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants