Penalty model lp #64
Merged
Penalty model lp #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
reviewed
Nov 19, 2018
arcondello
reviewed
Nov 19, 2018
arcondello
reviewed
Nov 19, 2018
arcondello
reviewed
Nov 19, 2018
arcondello
reviewed
Nov 19, 2018
m3ller
force-pushed
the
penalty-model-lp
branch
from
4ef562c
to
f08baa9
Compare
|
Note: there are a couple packages in penaltymodel-lp's |
arcondello
reviewed
Nov 23, 2018
added 18 commits
November 26, 2018 09:22
…ltymodel entrypoint for toy
…dditional valid state to make a proper or_gate
…y work for spin values, so replace bool-and with min(a,b)
…Add xor_gate test
added 13 commits
November 26, 2018 09:22
… generate_bqm(..)
… that unspecified states are based on gap + lowest-specified-energy
…an qubo; and deal with single tuple error. Add some energy range tests
m3ller
force-pushed
the
penalty-model-lp
branch
from
0594a64
to
84e54ca
Compare
…ments Also need to keep the dimod versions consistent accross the different requirements files
arcondello
reviewed
Nov 26, 2018
|
Also the file |
arcondello
reviewed
Nov 26, 2018
| setup( | ||
| name="penaltymodel-lp", | ||
| install_requires=install_requires, | ||
| entry_points={ |
There was a problem hiding this comment.
Need to add the packages
setup(
name="penaltymodel-lp",
install_requires=install_requires,
packages=packages,
entry_points={
FACTORY_ENTRYPOINT: ['lp = penaltymodel.lp:get_penalty_model']
}
)
In general this needs to have additional parameters added. I would use
as a templateThere was a problem hiding this comment.
except python_requires should be
python_requires = '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*'
There was a problem hiding this comment.
Okay. I'll push the change with the packages first to make sure it fixes the CI errors. If that passes, I'll switch over and follow mip's setup.py.
added 3 commits
November 26, 2018 11:10
…so it's not penaltymodel's job to test this. Penaltymodel only deals in ising.
|
Closes #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please just review; do not merge.
Unit tests,
test_generation.pyandtest_interface.pyare still a work in progress. (read: please don't review them as they will change).PR will add linear programming as a penalty model.