handleIgnore function - variable type error #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If (int)0 is used as a variable value in the $item array, the ignore function will unset it from the array. Added a type check into the IF to remedy.
dweeves
added a commit
that referenced
this pull request
Sep 19, 2013
handleIgnore function - variable type error
|
Hmm strange , but switching operands do not work , identity is the only way to fix this,well done ! feel free to continue to contribute, your help is really welcome. |
PatrickCronin
added a commit
to PatrickCronin/magmi-git
that referenced
this pull request
Jul 30, 2014
This problem prevented me from performing a stock update using a fresh install of Magmi 0.7.19a on a fresh install of Magento CE 1.9.0.1. I created two simple products in Magento and tried to update their stock information them using Magmi. I created a two-column CSV ("sku" and "qty") and attempted to import it. I got the following errors:
1 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null -
2 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null - ERROR ON RECORD dweeves#1
3 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null -
4 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null - ERROR ON RECORD dweeves#2
More details on this error are here: https://sourceforge.net/p/magmi/discussion/1228365/thread/8e722889/
I tracked the problem to filterkvarr(). If the $kvarr has values which are numerical 0's, the function changes their values to null. This is because var_dump(0 == '__NULL__'); // 0 == 0 -> true. However, var_dump(0 === '__NULL__'); // 0 !== '__NULL__' -> false. So I suggest this change. (See PHP's documentation on this: http://us1.php.net/operators.comparison).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If (int)0 is used as a variable value in the $item array, the ignore function will unset it from the array.
Added a type check into the IF to remedy.