Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Support http proxy #26

Closed
wants to merge 1 commit into from
Closed

Support http proxy #26

wants to merge 1 commit into from

Conversation

nighon
Copy link

@nighon nighon commented Aug 16, 2019

Just added feature supporting http proxy

add HTTP_PROXY inside .env

HTTP_PROXY=http://proxyhost:port

add config file goutte.php

<?php

return [
    'http_proxy' => env('HTTP_PROXY'),
];

@dweidner
Copy link
Owner

I would like to allow users to customize all available options of the Goutte client (see #18). Would it be possible, to simply call config('goutte') to retrieve the entire array defined in the config file?

@dweidner
Copy link
Owner

I have provided a new feature branch (feautre/config). Would be great if you could check that out and provide some feedback.

@nighon
Copy link
Author

nighon commented Aug 18, 2019

Yes, I have checked the code of branch feature/config. Everything is ok after I moved the directory config inside src.

Your solution is better than mine!

@dweidner
Copy link
Owner

Thank you for the hint, I fixed the path of the package configuration file

@dweidner
Copy link
Owner

Merged the latest feature branch

@dweidner dweidner closed this Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants