Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up dialog to search all server content #263

Closed
dweymouth opened this issue Oct 24, 2023 · 8 comments · Fixed by #272
Closed

Pop-up dialog to search all server content #263

dweymouth opened this issue Oct 24, 2023 · 8 comments · Fixed by #272
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dweymouth
Copy link
Owner

dweymouth commented Oct 24, 2023

Should be invoked with a shortcut and probably also a new button next to the settings menu button. Search results should include albums, artists, tracks, and playlists. The existing search field to search within specific pages would remain.

@dweymouth dweymouth added the enhancement New feature or request label Oct 24, 2023
@dweymouth dweymouth self-assigned this Oct 31, 2023
@dweymouth dweymouth added this to the 0.7.0 milestone Oct 31, 2023
@bbsixzz
Copy link

bbsixzz commented Nov 14, 2023

Great feature, could you please make the list resizable/larger so you don't have to scroll so much? Cheers

@dweymouth
Copy link
Owner Author

Making it larger I can do; user-resizable isn't supported by Fyne's popup API. I'll probably make its current size the minimum size, but if your app window is larger it will scale itself larger to a certain % of your window height. That is the same thing the popup cover art does, it takes up like 70% of vertical window space (don't remember the exact %)

@bbsixzz
Copy link

bbsixzz commented Nov 17, 2023

2 albums appear as 4 in the results.

Screenshot 2023-11-17 at 21 41 31
Screenshot 2023-11-17 at 21 41 17

@dweymouth
Copy link
Owner Author

I don't see that? I see the 2 albums, plus individual tracks from those albums

@bbsixzz
Copy link

bbsixzz commented Nov 17, 2023

The second image shows the first result highlighted with Artist - 4 albums

@dweymouth
Copy link
Owner Author

Oh, you're right, sorry I thought you were saying each album showed up twice in the results. I wonder if this is a Navidrome bug - did you just start seeing this after upgrading to 0.50.0? I just checked quickly and it doesn't repro with my library in 0.49.3

@dweymouth
Copy link
Owner Author

dweymouth commented Nov 17, 2023

Try accessing in the browser http://<your-navidrome-server>:<port>/rest/search3?query=aris%20kindt&u=<your-username>&p=<your-password>&v=1.16.0&c=supersonic&albumCount=0&songCount=0. Is the albumCount property 4 in the result under the artist entry?

@bbsixzz
Copy link

bbsixzz commented Nov 17, 2023

Yes

<artist id="73e161735eef64a3ab3ce5f142ae15b2" name="Aris Kindt" coverArt="ar-73e161735eef64a3ab3ce5f142ae15b2_0" albumCount="4"

[EDIT]

I did a full rescan of the library and it's now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants