Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prefix to the cache key. #28

Merged
merged 2 commits into from Aug 8, 2016
Merged

Add a prefix to the cache key. #28

merged 2 commits into from Aug 8, 2016

Conversation

ameliaikeda
Copy link
Contributor

This means that people on, say, Redis can drop all keys that match rememberable:*, and people with taggable stores can still identify rememberable cache entries.

@ameliaikeda ameliaikeda mentioned this pull request Jul 12, 2016
4 tasks
@ameliaikeda
Copy link
Contributor Author

Is there any progress towards accepting these yet?

@dwightwatson
Copy link
Owner

Apologies, I just got back from holiday. I've decided to move forward with these and work towards a new major release. But at least they'll be in dev-master for the meantime. I appreciate your patience while I mulled over what to do here.

@ameliaikeda
Copy link
Contributor Author

ameliaikeda commented Aug 8, 2016

That's fine; I went and hard-forked this repo to https://github.com/ameliaikeda/rememberable and published it, but I can throw upstream pull requests your way and drop the fork if it reaches feature parity; it's currently running in production with a new HMAC-based cache key system, so the entire query cache can be busted during deployments via rememberable:hmac.

@dwightwatson dwightwatson merged commit 005a02b into dwightwatson:master Aug 8, 2016
@dwightwatson
Copy link
Owner

Sounds good. I like your addition of the forget() method. I'm not familiar with HMAC so will take a look into that. I'll flick one of my production apps over to dev-master on this to keep an eye on it. Thanks again for all the work done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants