Added bsize module #4
Conversation
| self.assertEqual(Size("1.048576e+06B").get(), "1.0 MiB") | ||
|
|
||
| # accept units case insensitive, without space, convert | ||
| self.assertEqual(Size("1000kilObytes").get("autodec", "%d"), "1") |
There was a problem hiding this comment.
Shouldn't there be a unit on the return value?
There was a problem hiding this comment.
Not in this case. The second parameter of Size.get specifies the format of the value and units. %d asks only for value in int format. Units are added when %sb or %lb is used.
There was a problem hiding this comment.
I'm pretty sure module_utils is in the ansible core codebase and is only for functionality that could be expected to be used by the average module developer. This bsize module is only useful to the bsize module, so I think it should go into a file named something likesize.py instead.
library/bsize.py
Outdated
|
|
||
| # use whatever logic you need to determine whether or not this module | ||
| # made any modifications to your target | ||
| result['changed'] = True |
There was a problem hiding this comment.
This should probably be False since it is only gathering information and not changing anything on the system.
module_utils/bsize.py
Outdated
| "units" parameter allows to select preferred unit. | ||
| accepted values are also: | ||
| 'autobin' (default) - uses the highest human readable unit (binary) | ||
| 'autodec' - uses the highest human readable unit (decimal) |
There was a problem hiding this comment.
Since there are only two choices here I would suggest a boolean flag 'decimal' that defaults to None or False. It eliminates the free-form string and simplifies the method signature. I'd also make that flag the last argument.
There was a problem hiding this comment.
Hmm, maybe name it something else since there is a decimal module in the standard library of python.
There was a problem hiding this comment.
Actually there are more than two possible values. "units" parameter can be also set to specific units to which the value is converted. e.g. "kilobytes" or "MiB". Updated the comment to make it clearer.
| self.assertEqual(Size("1.048576e+06B").get(), "1.0 MiB") | ||
|
|
||
| # accept units case insensitive, without space, convert | ||
| self.assertEqual(Size("1000kilObytes").get("autodec", "%d"), "1") |
japokorn
force-pushed
the
master_bsize_module
branch
from
25d5c8a
to
870ac52
Compare
Added module util for basic work with byte sizes Added bsize module util test Added bsize module
japokorn
force-pushed
the
master_bsize_module
branch
from
870ac52
to
e2676b0
Compare
|
Reference for a bundled https://docs.ansible.com/ansible/latest/user_guide/playbooks_best_practices.html (See the "Directory Layout" section.) |
Added module util for basic work with byte sizes
Added bsize module util test
Added bsize module