Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is there an option to generate icon only for one platform? #32

Closed
vieraleonel opened this issue Jun 1, 2017 · 7 comments · Fixed by #34
Closed

Question: Is there an option to generate icon only for one platform? #32

vieraleonel opened this issue Jun 1, 2017 · 7 comments · Fixed by #34

Comments

@vieraleonel
Copy link

I would like to have different icons for Android and iOS (just for the background). Thanks. Great Work!

@dwmkerr
Copy link
Owner

dwmkerr commented Jun 2, 2017

Hi @vieraleonel great idea! I was thinking that maybe just adding a 'platform' flag would work, so it would be two calls like this:

app-icon -i android.png --platform android
app-icon -i ios.png --platform ios

This means we can add one new flag, instead of potentially two (like --icon-ios or --icon-android). Would that work for you?

@vieraleonel
Copy link
Author

That would be excellent!

@dwmkerr dwmkerr mentioned this issue Jun 2, 2017
dwmkerr added a commit that referenced this issue Jun 2, 2017
dwmkerr added a commit that referenced this issue Jun 2, 2017
feature: added platforms flag. closes #32.
@dwmkerr
Copy link
Owner

dwmkerr commented Jun 2, 2017

Try installing version 0.5, just published:

app-icon generate -i android.png --platforms android
app-icon generate -i ios.png --platforms ios

@vieraleonel
Copy link
Author

Working great! Just to make it perfect you should update README and --help option. I can make a PR this weekend if you like.

@vieraleonel
Copy link
Author

Sorry I just see --help option has the documentation. So only a README update

@dwmkerr dwmkerr reopened this Jun 4, 2017
@dwmkerr
Copy link
Owner

dwmkerr commented Jun 4, 2017

@vieraleonel good point, I totally forgot the README! I'll update it 👍

@dwmkerr
Copy link
Owner

dwmkerr commented Jun 5, 2017

I think we're covered with #35 now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants