Query all #54

SimonLab · 2019-03-06T08:26:19Z

ref: #40

This PR is based on #50 (thanks @RobStallion , it's much easier to have a common base 👍 )

When Repo.all(query) is called we need to

order the elements of the query by inserted_at value
add "distinct on" the entry_id to make sure to get the latest version of the item
Then with the two added points above, create a subquery and select only the element of these subquery which are not deleted

RobStallion · 2019-03-06T16:03:06Z

@SimonLab this is looking really good 👍

lib/alog/connection.ex

add "distinct on" in query, #40

8c6d232

SimonLab added the in-progress label Mar 6, 2019

SimonLab self-assigned this Mar 6, 2019

SimonLab added 3 commits March 6, 2019 13:09

use regex instead of String.split to match query terms, #40 (comment)

c934649

order by result by entry_id and inserted_at, #40

0eb4ce5

create subquery for all function, #40

2c4f4a2

SimonLab changed the base branch from master to adapter March 11, 2019 14:32

SimonLab commented Mar 11, 2019

View reviewed changes

lib/alog/connection.ex Outdated Show resolved Hide resolved

Simon and others added 3 commits March 11, 2019 14:35

Update lib/alog/connection.ex

abf0f46

check deleted field is necessary on subquery, #40

53c92d1

add test for all, #40

d9eb8b9

SimonLab requested a review from Danwhy March 12, 2019 10:05

SimonLab assigned Danwhy and unassigned SimonLab Mar 12, 2019

SimonLab added awaiting-review and removed in-progress labels Mar 12, 2019

Danwhy approved these changes Mar 12, 2019

View reviewed changes

Danwhy merged commit fd63ef5 into adapter Mar 12, 2019

Danwhy deleted the query-all branch March 12, 2019 15:45

Provide feedback