Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show started capture on top of the captures list #41

Open
SimonLab opened this issue Apr 3, 2020 · 1 comment
Open

Show started capture on top of the captures list #41

SimonLab opened this issue Apr 3, 2020 · 1 comment
Assignees
@SimonLab
Labels
awaiting-review enhancement New feature or request T1h
Projects
dwyl app

Comments

@SimonLab
Copy link
Member

SimonLab commented Apr 3, 2020

Now that we have a way to sort captures by status, see #40 one solution to make sure a started capture is displayed on top of the list is to sort the list by "InProgress" when a timer is started.

Doing this way keep the sorting consistent and avoid having a started capture on top of the list while the sorting is different.
@SimonLab SimonLab added enhancement New feature or request T1h labels Apr 3, 2020
@SimonLab SimonLab self-assigned this Apr 3, 2020
@SimonLab SimonLab added this to To do in dwyl app via automation Apr 3, 2020
@SimonLab
Copy link
Member Author

SimonLab commented Apr 3, 2020

This can in fact easily implemented as we just need to update the sortCaptures state of the model when a timer is started:
start-sort

SimonLab added a commit that referenced this issue Apr 3, 2020
@SimonLab
sort started timer, #41
49a40c8
@SimonLab SimonLab mentioned this issue Apr 3, 2020
Merged
SimonLab added a commit that referenced this issue Apr 6, 2020
@SimonLab
Merge branch 'master' into sort-inprogress-capture-#41
cee8d2b
SimonLab added a commit that referenced this issue Apr 6, 2020
@SimonLab
test compare captures status #41
76e753c
@SimonLab SimonLab moved this from To do to Awaiting review in dwyl app Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review enhancement New feature or request T1h
Projects
dwyl app
  
Awaiting review
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SimonLab