Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use Usernames? #22

Closed
nelsonic opened this issue Jun 8, 2018 · 1 comment
Closed

Should we use Usernames? #22

nelsonic opened this issue Jun 8, 2018 · 1 comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue question A question needs to be answered before progress can be made on this issue

Comments

@nelsonic
Copy link
Member

nelsonic commented Jun 8, 2018

https://www.b-list.org/weblog/2018/feb/11/usernames/
via: https://news.ycombinator.com/item?id=16356397
@nelsonic nelsonic added question A question needs to be answered before progress can be made on this issue discuss Share your constructive thoughts on how to make progress with this issue labels Jun 8, 2018
@nelsonic nelsonic mentioned this issue Jun 8, 2018
Closed
@nelsonic nelsonic mentioned this issue Apr 1, 2020
Closed
8 tasks
@nelsonic
Copy link
Member Author

We have the concept of username on person schema:

auth/lib/auth/person.ex

Lines 22 to 23 in fde3b66

field :username, :binary
field :username_hash, Fields.Hash

But we are not allowing people to register or login using a username (for now...).
We are merely inserting the GitHub username when the person logs in using GitHub auth.
If we decide to enable this feature in the future, we can create a new issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Share your constructive thoughts on how to make progress with this issue question A question needs to be answered before progress can be made on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic