Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs a bit of cleanup #4

Closed
huttarl opened this issue Dec 1, 2016 · 14 comments
Closed

needs a bit of cleanup #4

huttarl opened this issue Dec 1, 2016 · 14 comments
Labels
bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment!

Comments

@huttarl
Copy link

huttarl commented Dec 1, 2016

It's very handy to have this list.
It does have a few non-words in it, possibly due to OCR errors. A couple I caught were

  • brainwashjng
  • neritjc
@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment! labels Dec 1, 2016
@nelsonic
Copy link
Member

nelsonic commented Dec 1, 2016

@huttarl thanks a bunch for reporting this issue!
Would you mind opening the source file in SublimeText, editing the offending word and submitting a Pull Request to update it?

I've invited you to be a collaborator on the repo: https://github.com/dwyl/english-words/invitations
and to be a member of DWYL: https://github.com/dwyl so you can create branches on the repo without having to fork.

Thanks! ❤️

@huttarl
Copy link
Author

huttarl commented Dec 1, 2016

Thanks for the invitation.

There's a lot more cleanup that could be done. It would be a substantial undertaking. If I invested that kind of time into an open-source word list -- which could be worthwhile -- I'd want to make sure it was one with a clear copyright / license / permission terms, which this one doesn't seem to have.

@nelsonic
Copy link
Member

nelsonic commented Dec 1, 2016

@huttarl please suggest the appropriate license. The words come from a couple of sources, but I don't know that much about Copyright for an alphabetical list of words ... would have thought Creative Commons would be good but honestly don't know.
Of the hundreds of people who have used the list you are only the second person to contribute back (even just open the issue is greatly appreciated!)
Thanks again! 👍

@huttarl
Copy link
Author

huttarl commented Dec 1, 2016

I would think any license would have to be consistent with the permissions of the original source(s). But the only source listed in the README.md is infochimps (with "Copyright still belongs to them"), and since the link to infochimps is broken, I don't know what the constraints are.

@Smadarl
Copy link

Smadarl commented Jan 4, 2017

Imported this into a TRIE tree, and found a single duplicate word: animate. Appears everything else is unique.

@nelsonic
Copy link
Member

nelsonic commented Jan 4, 2017

@Smadarl thanks for confirming that!
I think the animate duplicate has now been removed: #5 ...?

@mikestopcontinues
Copy link
Contributor

For a word list, the public domain feels right, doesn't it? You can use CC0 to declare it:
https://creativecommons.org/share-your-work/public-domain/cc0/

@nelsonic
Copy link
Member

nelsonic commented Jan 6, 2017

@mikestopcontinues I agree, "Public Domain" feels appropriate for this list.
I never understood how an alphabetical list of english words could be copyrightable in the first place. But then I'm not a lawyer/legal-expert and most of the time I don't understand why people/companies feel the need to restrict usage of things which incur no incremental cost and result in no "loss" to the original creator...

If anyone has time to add the https://creativecommons.org/share-your-work/public-domain/cc0/ license as a Pull Request we'd gladly accept it! ✅

@dacbarbos
Copy link

dacbarbos commented Jan 21, 2017

While I salute the PD-icon license choice, I still believe it would be wise of you to get a "written" agreement from CSC to avoid future "surprises".

@huttarl
Copy link
Author

huttarl commented Jan 21, 2017

I agree with @dacbarbos... It's fine to discuss what we'd like the license to be, but until we know what restrictions infochimps has or hasn't put on the list, it seems like a moot point.

@dacbarbos
Copy link

I love seeing how GitHub is growing every year, practically becoming the new Wikipedia for OSI supporters. While poking around, I found another interesting repo.

@nelsonic
Copy link
Member

@dacbarbos that's such a cool/useful list for people learning English! 👍
good find! thanks for sharing!

@dacbarbos
Copy link

:octocat: rulez! sharing is caring...

@devzilenas devzilenas mentioned this issue Jun 1, 2017
@nelsonic
Copy link
Member

Cleanup performed in #11
Considering "fixed". ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment!
Projects
None yet
Development

No branches or pull requests

4 participants