-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Socket.io Polling not working :-( #69
Comments
Well... this might be my fault. It turns out the new socket.io js client file we included doesn't "work". Not sure why that is. If we include the original file, https://cdn.socket.io/socket.io-1.3.5.js It works. The issue we were having was that link was broken, but today, it seems the link has fixed itself. So if we didn't change anything and just waited a day it would have fixed itself haha. Anyways, I'm sorry about this, I can either create a new branch with the original link or we could revert to the commit before the merge? I pulled in the code as-is and then just changed the socket.io client JS file to the one above on my digitalocean box, and it seems to work: http://107.170.109.97:8000/ Thanks and sorry again for the troubles. |
@Shivang44 cool. let's go back to the previous version. do you have time to PR? 👍 |
@nelsonic Done. It might have had to do with the version differences (1.3.5 vs 1.4.6). |
@Shivang44 thanks for helping to debug this. |
@nelsonic That's really strange. I stopped my server, pulled in the latest repo, and just ran it as-is. Works for me. I'll take a deeper look at later today, but I think you and your team know much more about nodejs and websockets than me. :) Nevertheless, I'll make a new PR if I do figure it out. Thanks for spending time merging the PR's! |
@nelsonic Is this resolved? It seems to work on the link you posted. |
@Shivang44 yes, it appears to be working as expected.
Thanks again! 👍 |
https://hapi-chat.herokuapp.com/
![socket-io-polling-not-working](https://cloud.githubusercontent.com/assets/194400/15652784/8a216376-2680-11e6-8c11-472923b5c4d8.png)
sad panda ... 🐼 😢
The text was updated successfully, but these errors were encountered: