Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io Polling not working :-( #69

Closed
nelsonic opened this issue May 30, 2016 · 7 comments
Closed

Socket.io Polling not working :-( #69

nelsonic opened this issue May 30, 2016 · 7 comments

Comments

@nelsonic
Copy link
Member

https://hapi-chat.herokuapp.com/
socket-io-polling-not-working

sad panda ... 🐼 😢

@Shivang44
Copy link
Contributor

Shivang44 commented May 30, 2016

Well... this might be my fault. It turns out the new socket.io js client file we included doesn't "work". Not sure why that is.

If we include the original file,

https://cdn.socket.io/socket.io-1.3.5.js

It works. The issue we were having was that link was broken, but today, it seems the link has fixed itself. So if we didn't change anything and just waited a day it would have fixed itself haha. Anyways, I'm sorry about this, I can either create a new branch with the original link or we could revert to the commit before the merge?

I pulled in the code as-is and then just changed the socket.io client JS file to the one above on my digitalocean box, and it seems to work: http://107.170.109.97:8000/

Thanks and sorry again for the troubles.

@nelsonic
Copy link
Member Author

@Shivang44 cool. let's go back to the previous version. do you have time to PR? 👍

@Shivang44
Copy link
Contributor

@nelsonic Done. It might have had to do with the version differences (1.3.5 vs 1.4.6).

@nelsonic
Copy link
Member Author

@Shivang44 thanks for helping to debug this.
the older version of Socket.io has been deployed to the app: view-source:https://hapi-chat.herokuapp.com/ but the issue is still there. sad times. 😞

@Shivang44
Copy link
Contributor

Shivang44 commented May 30, 2016

@nelsonic That's really strange. I stopped my server, pulled in the latest repo, and just ran it as-is. Works for me. I'll take a deeper look at later today, but I think you and your team know much more about nodejs and websockets than me. :)

Nevertheless, I'll make a new PR if I do figure it out. Thanks for spending time merging the PR's!

@Shivang44
Copy link
Contributor

@nelsonic Is this resolved? It seems to work on the link you posted.

@nelsonic
Copy link
Member Author

nelsonic commented Jun 1, 2016

@Shivang44 yes, it appears to be working as expected.
hapi-socketio-redis-chat-example-working

No console errors. ✅

Thanks again! 👍

@nelsonic nelsonic closed this as completed Jun 1, 2016
@ZooeyMiller ZooeyMiller mentioned this issue Jun 26, 2017
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants