Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md #70

Merged
merged 2 commits into from May 4, 2017
Merged

Fix typo in README.md #70

merged 2 commits into from May 4, 2017

Conversation

tomaszbakula
Copy link
Contributor

No description provided.

@nelsonic
Copy link
Member

nelsonic commented May 3, 2017

@tomaszbakula thanks for fixing the typo. 👍
We are investigating why the Travis-CI build is failing ... 🔍 ⌛️

@nelsonic
Copy link
Member

nelsonic commented May 3, 2017

@tomaszbakula could you please rebase on master to get the changes in .travis.yml and package.json? hopefully that will ensure that the build passes on your Pull Request and we can merge your typo fix. thanks! 👍

@tomaszbakula
Copy link
Contributor Author

@nelsonic It looks like it's ok now but I'm not sure if I've done this correctly because I couldn't find the 7cca7ee commit in the git log.

@nelsonic
Copy link
Member

nelsonic commented May 4, 2017

@tomaszbakula thanks for updating. 👍
merge commits do not alter the state of the log they merely include commits from other branches/logs so don't worry about not finding it 😉
Welcome to @dwyl ! ❤️ ✅ 🚀

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomaszbakula thanks for taking the time to fix the typo! 🥇
(hundreds of other people have read this doc and not made the time so I really appreciate it!)

@nelsonic nelsonic merged commit 6377f0c into dwyl:master May 4, 2017
@tomaszbakula
Copy link
Contributor Author

No worries @nelsonic :) it's always good to do something for the community, even such a small thing like a typo fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants