Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Single-Click/Tap link to open link or item.text to Edit #444

Open
nelsonic opened this issue Nov 20, 2023 · 2 comments
Open

Feat: Single-Click/Tap link to open link or item.text to Edit #444

nelsonic opened this issue Nov 20, 2023 · 2 comments
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes.

Comments

@nelsonic
Copy link
Member

This is the final requirement in #141
We need to check if the DOM node being clicked/tapped is an <a> tag and if it is, don't enter Edit mode.

Should be straightforward to intercept the click/tap event.
Unless it's all in a phx-click black box ... 💭

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. discuss Share your constructive thoughts on how to make progress with this issue chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code labels Nov 20, 2023
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Nov 20, 2023
@nelsonic
Copy link
Member Author

The code is currently:

<label
class="w-full flex-auto text-slate-800 m-2"
phx-click="edit-item"
phx-value-id={item.id}
phx-value-cid={item.cid}
>
<%= item.text %>
</label>

@nelsonic
Copy link
Member Author

nelsonic commented Nov 20, 2023

I've made some progress with intercepting the click event ... but still getting errors. 😢

Will return to this later. ⏳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes.
Projects
Nelson's List
  
More ToDo ThanCanEver Be Done
Status: No status
Development

No branches or pull requests

1 participant