Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

orchestrator:release --dryrun still attempts to install packages #1340

Closed
chips5k opened this issue Jul 4, 2023 · 2 comments
Closed

orchestrator:release --dryrun still attempts to install packages #1340

chips5k opened this issue Jul 4, 2023 · 2 comments
Assignees
@azlam-abdulsalam
Labels
bug Something isn't working
Milestone
July 23

Comments

@chips5k
Copy link

chips5k commented Jul 4, 2023

Describe the bug
When running orchestrator:release with the dryrun flag, it attempts to install packages when it should not.

To Reproduce
Steps to reproduce the behavior:
Modify packageDependencies in release yml to cause a change.
Run orchestrator:release with dryrun flag.

Expected behavior
With dry run flag enabled, no modification to any environments should occur.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform Details (please complete the following information):

  • OS: docker
  • Version latest
  • Salesforce CLI(sfdx cli) Version: latest

Additional context
This has been fixed in the past, but seems to have returned:
#774
2a472f0
@github-actions github-actions bot added the analysis To be decided on how to solution/fix label Jul 4, 2023
@azlam-abdulsalam
Copy link
Contributor

Thanks @chips5k .. Will address this soon!

@azlam-abdulsalam azlam-abdulsalam added bug Something isn't working and removed analysis To be decided on how to solution/fix labels Jul 4, 2023
@azlam-abdulsalam azlam-abdulsalam self-assigned this Jul 4, 2023
@azlam-abdulsalam azlam-abdulsalam added this to the July 23 milestone Jul 18, 2023
@azlam-abdulsalam
Copy link
Contributor

Fixed in July23

azlam-abdulsalam added a commit that referenced this issue Aug 11, 2023
@azlam-abdulsalam
fix(release): ensure dependencies are not installed during dryun
e1e3e76 
dryrun option was not supported during release for dependencies

fixes #1340
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@azlam-abdulsalam azlam-abdulsalam

Labels
bug Something isn't working
Projects
None yet
Milestone
July 23
Development

No branches or pull requests
2 participants
@chips5k @azlam-abdulsalam