Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(package): add support for package directories without name and version #1028

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Jun 9, 2022

Remove restriction on packageDirectories without package and versionNumber keys such as src-temp. Such packages will
automatically ignored by orchestrator on all stages.

fixes #842

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@codecov-commenter
Copy link

Codecov Report

Merging #1028 (b22298c) into develop (3961072) will decrease coverage by 0.24%.
The diff coverage is 53.84%.

@@             Coverage Diff             @@
##           develop    #1028      +/-   ##
===========================================
- Coverage    58.37%   58.13%   -0.25%     
===========================================
  Files           51       51              
  Lines         1576     1598      +22     
  Branches       332      340       +8     
===========================================
+ Hits           920      929       +9     
- Misses         613      626      +13     
  Partials        43       43              
Impacted Files Coverage Δ
packages/core/src/project/ProjectConfig.ts 76.19% <45.45%> (-12.88%) ⬇️
...ckages/sfpowerscripts-cli/src/ProjectValidation.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3961072...b22298c. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 7baface into develop Jun 10, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the issue/842 branch June 10, 2022 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants