Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(sfp-package): add support for unpackaged metadata in unlocked packages #1056

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Jun 16, 2022

Add support for unpackaged metadata. This was removed as sfpowerscripts do parallel build of unlocked packages in individual working directory and
working directory didnt copy the unpackaged directory. Support is added to copy unpackaged directory
and copy the folder to appropriate working directory. sfdx-project.json is then aligned for
sucessful preparation of the package. The unpackaged is a package directory and it will be upto the
user to determine the behaviour during validate,prepare or deploy. This along with changes in #842
which will skip the directories which doesnt have package name or version number, but will get
still picked up during 'push'

fix #958

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

…ckages

Add support for unpackaged metadata. This was removed as sfpowerscripts do parallel development and
working directory didnt copy the unpackaged directory. Support is added to copy unpackaged directory
and copy the folder to appropriate working directory. sfdx-project.json is then aligned for
sucessful preparation of the package. The unpackaged is a package directory and it will be upto the
user to determine the behaviour during validate,prepare or deploy. This along with changes in #842
which will skip the directories

fix #958
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1056 (e92ff56) into develop (d0291e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1056   +/-   ##
========================================
  Coverage    59.55%   59.55%           
========================================
  Files           52       52           
  Lines         1674     1674           
  Branches       357      357           
========================================
  Hits           997      997           
  Misses         634      634           
  Partials        43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8776d7...e92ff56. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 6c04f6d into develop Jun 16, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the issue/958 branch June 16, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sfdx-project.json validation incorrectly rejecting unpackagedMetadata
4 participants