Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix issue/1180 #1181

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix issue/1180 #1181

merged 2 commits into from
Jan 10, 2023

Conversation

gz77a
Copy link
Contributor

@gz77a gz77a commented Dec 20, 2022

Hi Azlam,

Adding a fix for this issue. Local test works as expected, but not sure if it's the completed fix. Please kindly advice.

Also need to add this component to ReleaseDefinition.test.ts.

Thanks

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@codecov-commenter
Copy link

Codecov Report

Base: 53.68% // Head: 53.68% // No change to project coverage 👍

Coverage data is based on head (515ab17) compared to base (0c4ea53).
Patch has no changes to coverable lines.

❗ Current head 515ab17 differs from pull request most recent head 0c7c7d0. Consider uploading reports for the commit 0c7c7d0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1181   +/-   ##
========================================
  Coverage    53.68%   53.68%           
========================================
  Files           70       70           
  Lines         3176     3176           
  Branches       681      698   +17     
========================================
  Hits          1705     1705           
  Misses        1471     1471           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azlam-abdulsalam
Copy link
Contributor

Thanks @gz77a for the fix. Looks good

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azlam-abdulsalam azlam-abdulsalam merged commit f47a449 into dxatscale:develop Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants