Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Prevent from downloading / creating artifacts that are not used… #1223

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Prevent from downloading / creating artifacts that are not used… #1223

merged 3 commits into from
Feb 27, 2023

Conversation

michallachowski
Copy link
Contributor

This change improves performance of orchestrator:prepare command, as it prevents from download / creation of packages that won't be used in the pipeline run.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label Feb 15, 2023
@azlam-abdulsalam
Copy link
Contributor

Thanks @michallachowski .. looks good.. just checking any edge conditions we haven't handled and will make it available for Feb release

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Base: 60.37% // Head: 60.37% // No change to project coverage 👍

Coverage data is based on head (15b0877) compared to base (2ff8533).
Patch has no changes to coverable lines.

❗ Current head 15b0877 differs from pull request most recent head b1fb006. Consider uploading reports for the commit b1fb006 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   60.37%   60.37%           
=======================================
  Files          64       64           
  Lines        2130     2130           
  Branches      454      454           
=======================================
  Hits         1286     1286           
  Misses        844      844           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azlam-abdulsalam azlam-abdulsalam merged commit 55818b7 into dxatscale:main Feb 27, 2023
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@michallachowski michallachowski deleted the 1222-orchestrator-prepare-improvement branch February 27, 2023 22:59
@azlam-abdulsalam azlam-abdulsalam changed the title #1222 prevent from downloading / creating artifacts that are not used… Prevent from downloading / creating artifacts that are not used… Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants