This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
feat(pool): recover orphaned scratch orgs #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scratch orgs when created during prepare can be timed out at the client side (aka at the execution of prepare), however these scratch orgs might get created in the backend and consume an active limit, but is not recovered by sfpowerscripts upon delete. Users have to manually delete thes orgs out or wait till these orgs are expired, so that the active limits are back. This functionality uses description filed to determine which scratch orgs were requested by sfpowerscripts and then proceed to delete during an execution of prepare command before and after the pools are created
Codecov ReportBase: 60.48% // Head: 60.48% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
=======================================
Coverage 60.48% 60.48%
=======================================
Files 64 64
Lines 2126 2126
Branches 453 453
=======================================
Hits 1286 1286
Misses 788 788
Partials 52 52 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zhebinliu
approved these changes
Feb 15, 2023
packages/core/src/scratchorg/pool/services/fetchers/ScratchOrgInfoFetcher.ts
Outdated
Show resolved
Hide resolved
packages/core/src/scratchorg/pool/services/fetchers/ScratchOrgInfoFetcher.ts
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
=======================================
Coverage ? 60.48%
=======================================
Files ? 64
Lines ? 2126
Branches ? 453
=======================================
Hits ? 1286
Misses ? 788
Partials ? 52 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
azlam-abdulsalam
added a commit
that referenced
this pull request
Feb 15, 2023
This reverts commit 0c18540.
azlam-abdulsalam
added a commit
that referenced
this pull request
Feb 15, 2023
azlam-abdulsalam
added a commit
that referenced
this pull request
Feb 16, 2023
* feat(pool): recover orphaned scratch orgs Scratch orgs when created during prepare can be timed out at the client side (aka at the execution of prepare), however these scratch orgs might get created in the backend and consume an active limit, but is not recovered by sfpowerscripts upon delete. Users have to manually delete thes orgs out or wait till these orgs are expired, so that the active limits are back. This functionality uses description filed to determine which scratch orgs were requested by sfpowerscripts and then proceed to delete during an execution of prepare command before and after the pools are created * [CodeFactor] Apply fixes * Apply suggestions from code review --------- Co-authored-by: codefactor-io <support@codefactor.io>
azlam-abdulsalam
added a commit
that referenced
this pull request
Feb 16, 2023
* feat(pool): recover orphaned scratch orgs (#1234) * feat(pool): recover orphaned scratch orgs Scratch orgs when created during prepare can be timed out at the client side (aka at the execution of prepare), however these scratch orgs might get created in the backend and consume an active limit, but is not recovered by sfpowerscripts upon delete. Users have to manually delete thes orgs out or wait till these orgs are expired, so that the active limits are back. This functionality uses description filed to determine which scratch orgs were requested by sfpowerscripts and then proceed to delete during an execution of prepare command before and after the pools are created * [CodeFactor] Apply fixes * Apply suggestions from code review --------- Co-authored-by: codefactor-io <support@codefactor.io> * fix(pool): move recovery of orphaned orgs to delete recovery of oprhaned scratch orgs are moved to the delete command, with an addition of '-o' flag. This will alllow the user to run dur --------- Co-authored-by: codefactor-io <support@codefactor.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratch orgs when created during prepare can be timed out at the client side (aka at the execution
of prepare), however these scratch orgs might get created in the backend and consume an active
limit, but is not recovered by sfpowerscripts upon delete. Users have to manually delete thes orgs
out or wait till these orgs are expired, so that the active limits are back.
This functionality uses description field to determine which scratch orgs were requested by sfpowerscripts and then
proceed to delete during an execution of prepare command before and after the pools are created
Checklist
All items have to be completed before a PR is merged