Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(prepare): ensure prepare in build mode respects releaseconfig #1281

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(prepare): ensure prepare in build mode respects releaseconfig #1281

merged 1 commit into from
Mar 30, 2023

Conversation

azlam-abdulsalam
Copy link
Contributor

Prepare while in build mode was not respecting the passed in release config.
This fix is to ensure prepare respects the same

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

fix(prepare): ensure prepare in build mode respects releaseconfig
b3f7225 
Prepare while in build mode was not respecting the passed in release config. This fix is to ensure
prepare respects the same
@azlam-abdulsalam azlam-abdulsalam linked an issue Mar 30, 2023 that may be closed by this pull request
Ensure prepare respects releaseConfig when fetchArtifacts is not provided #1277
Closed
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Mar 30, 2023
@reviewpad
Copy link

reviewpad bot commented Mar 30, 2023

AI-Generated Pull Request Summary: This pull request includes a fix for the prepare step in build mode to ensure it respects the release configuration provided. A new function, includeOnlyPackagesAsPerReleaseConfig, has been added to filter packages based on the release configuration. This function also logs the filtered packages for better visibility.

@reviewpad reviewpad bot requested a review from zhebinliu March 30, 2023 03:39
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Mar 30, 2023
@azlam-abdulsalam azlam-abdulsalam merged commit ee3e827 into main Mar 30, 2023
@reviewpad reviewpad bot requested a review from ethan-sargent March 30, 2023 03:40
@azlam-abdulsalam azlam-abdulsalam deleted the 1277-ensure-prepare-respects-releaseconfig-when-fetchartifacts-is-not-provided branch March 30, 2023 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhebinliu zhebinliu zhebinliu approved these changes

@ethan-sargent ethan-sargent Awaiting requested review from ethan-sargent

Assignees
No one assigned
Labels
bug Something isn't working small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure prepare respects releaseConfig when fetchArtifacts is not provided
2 participants
@azlam-abdulsalam @zhebinliu