Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix: enable json flag for pool fetch command #1404

Merged

Conversation

RobinWeymans
Copy link
Contributor

@RobinWeymans RobinWeymans commented Sep 6, 2023

The --json flag is currently not available for the sf pool fetch command while it is available for other pool commands. This PR adds the json flag and suppresses non-json log output.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 6, 2023
@RobinWeymans RobinWeymans changed the title enable json flag for pool fetch command fix: enable json flag for pool fetch command Sep 6, 2023
@RobinWeymans
Copy link
Contributor Author

Hi @azlam-abdulsalam, is this something that could make it into a new version?

We're trying to update our CICD pipelines to this newer version but we're missing the following functionality. The older sfdx command sfdx sfpowerkit:pool:fetch does have --json flag so this might just be an oversight.

@azlam-abdulsalam
Copy link
Contributor

Thanks @RobinWeymans , will have a look and merge it in.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7846c2d) 46.87% compared to head (1348ba9) 46.87%.

❗ Current head 1348ba9 differs from pull request most recent head a24d5a7. Consider uploading reports for the commit a24d5a7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   46.87%   46.87%           
=======================================
  Files          70       70           
  Lines        2658     2658           
  Branches      308      308           
=======================================
  Hits         1246     1246           
  Misses       1384     1384           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

@azlam-abdulsalam azlam-abdulsalam merged commit f16dec3 into dxatscale:main Sep 16, 2023
4 checks passed
@azlam-abdulsalam azlam-abdulsalam added this to the August 23 milestone Sep 17, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 17, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'enable json flag for pool fetch command' (38c9515)
  • Unconventional commit detected: 'Merge branch 'main' into feature/enable-json-pool-fetch' (59112ff)
  • Unconventional commit detected: 'Merge branch 'main' into feature/enable-json-pool-fetch' (a24d5a7)

⚠️ Warnings

  • Please link an issue to the pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants