Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix: display login URL instead of instance URL for scratch orgs #1432

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: display login URL instead of instance URL for scratch orgs #1432

merged 1 commit into from
Oct 26, 2023

Conversation

michallachowski
Copy link
Contributor

This PR corrects a bug that appears when --orginfo parameter is provided for sfpowerscripts orchestrator:validate command. The method that generates markdown with org info details is failing due to undefined scratchOrg.instanceURL property - as a result it is completely blocking ability to validate changes.

I think we can simply replace that by loginURL, which is populated and contains contains expected info.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78cab45) 46.86% compared to head (2de0ae5) 46.86%.

❗ Current head 2de0ae5 differs from pull request most recent head 7e9c6cc. Consider uploading reports for the commit 7e9c6cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1432   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      313      313           
=======================================
  Hits         1249     1249           
  Misses       1386     1386           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michallachowski
Copy link
Contributor Author

michallachowski commented Oct 26, 2023

@azlam-abdulsalam I saw your comment in the code about required unification of OrgInfoDisplayer methods for sfpOrg and scratchOrg objects - I'll try to do some improvements there as well.

//TODO: Not ideal need to unify sfpOrg and scratchOrg and then make this a global method

@azlam-abdulsalam
Copy link
Contributor

Awesome thanks @michallachowski , keep them coming

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azlam-abdulsalam azlam-abdulsalam merged commit ccdc73f into dxatscale:main Oct 26, 2023
4 checks passed
@azlam-abdulsalam azlam-abdulsalam added this to the December 23 milestone Oct 26, 2023
@azlam-abdulsalam azlam-abdulsalam changed the title display login URL instead of instance URL for scratch orgs fix: display login URL instead of instance URL for scratch orgs Oct 26, 2023
@reviewpad
Copy link

reviewpad bot commented Oct 26, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'display login URL instead of instance URL for scratch orgs' (7e9c6cc)

⚠️ Warnings

  • Please link an issue to the pull request

@michallachowski michallachowski deleted the orginfo-displayer-issue branch October 26, 2023 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants