Merge pull request #1585 from dxc-technology/gomezivann-fix-localization

Fixing Localization page error
dxc-technology · May 3, 2023 · f53d80b · f53d80b
2 parents abf35d9 + 5047fdd
commit f53d80b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/lib/src/HalstackContext.tsx b/lib/src/HalstackContext.tsx
@@ -350,8 +350,7 @@ const parseTheme = (theme: DeepPartial<OpinionatedTheme>): AdvancedTheme => {
 };
 
 const parseLabels = (labels: DeepPartial<TranslatedLabels>): TranslatedLabels => {
-  const parsedLabels = JSON.parse(JSON.stringify(defaultTranslatedComponentLabels));
-
+  const parsedLabels = defaultTranslatedComponentLabels;
   Object.keys(labels).map((component) => {
     if (parsedLabels[component]) {
       Object.keys(parsedLabels[component]).map((label) => {

diff --git a/lib/src/accordion/Accordion.stories.tsx b/lib/src/accordion/Accordion.stories.tsx
@@ -131,7 +131,7 @@ export const Chromatic = () => (
       <DxcAccordion
         label="Accordion"
         assistiveText="Assistive text"
-        icon="https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons/images/icon-and-image-large-icon-settings_2x.png"
+        icon="https://www.freepnglogos.com/uploads/facebook-logo-design-1.png"
       >
         <div>
           Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse malesuada lacus ex, sit amet blandit leo

diff --git a/lib/src/button/Button.stories.tsx b/lib/src/button/Button.stories.tsx
@@ -98,7 +98,7 @@ export const Chromatic = () => (
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Big icon (image)" theme="light" level={4} />
-      <DxcButton icon="https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons/images/icon-and-image-large-icon-settings_2x.png" />
+      <DxcButton icon="https://www.freepnglogos.com/uploads/facebook-logo-design-1.png" />
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Small icon" theme="light" level={4} />

diff --git a/website/screens/principles/localization/examples/translations.ts b/website/screens/principles/localization/examples/translations.ts
@@ -24,8 +24,8 @@ const code = `() => {
       clearFieldActionTitle: "Limpiar",
     },
     paginator: {
-      itemsPerPageText: " Número de elementos",
-      pageOfText: (a, b) => \`Pagina: \${a} de \${b}\`,
+      itemsPerPageText: "Número de elementos: ",
+      pageOfText: (a, b) => \`Página: \${a} de \${b}\`,
     },
   };