Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosuggest roles are inconsistent due to Radix Popover #1336

Closed
GomezIvann opened this issue Oct 17, 2022 · 0 comments · Fixed by #1337
Closed

Autosuggest roles are inconsistent due to Radix Popover #1336

GomezIvann opened this issue Oct 17, 2022 · 0 comments · Fixed by #1337
Assignees
Labels
bug Something isn't working jira This task is referenced in a story of Jira

Comments

@GomezIvann
Copy link
Collaborator

GomezIvann commented Oct 17, 2022

Describe the bug
Radix Popover is adding new roles to inputs the main container even when the text input doesn't have the Autosuggest functionality, which makes it inconsistent with the regular textbox roles.

Expected behaviour
Have a conditional DOM tree implementation with the Radix popover depending on the presence of the suggestions prop.

Screenshots
Lighthouse accessibility report:
image

Additional context
Elements must only use allowed ARIA attributes.

@GomezIvann GomezIvann added the bug Something isn't working label Oct 17, 2022
@GomezIvann GomezIvann self-assigned this Oct 17, 2022
@GomezIvann GomezIvann added the jira This task is referenced in a story of Jira label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira This task is referenced in a story of Jira
Projects
Development

Successfully merging a pull request may close this issue.

1 participant