Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosuggest update to avoid inconsistent roles with Radix #1337

Merged
merged 6 commits into from Oct 20, 2022
Merged

Autosuggest update to avoid inconsistent roles with Radix #1337

merged 6 commits into from Oct 20, 2022

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 17, 2022 •
edited

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Now Radix Popover's presence depends on whether the text input is an autosuggest. This has been done with a conditional wrapper.

Closes #1336

@GomezIvann GomezIvann marked this pull request as ready for review October 17, 2022 15:54
@Jialecl Jialecl self-requested a review October 18, 2022 07:50
@Jialecl Jialecl self-assigned this Oct 18, 2022
@Jialecl Jialecl merged commit 4dc6bb3 into master Oct 20, 2022
@Jialecl Jialecl deleted the gomezivann-textInput-fix branch October 20, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autosuggest roles are inconsistent due to Radix Popover
2 participants
@GomezIvann @Jialecl