Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drowdown in Application layout header has bigger height #1451

Closed
aidamag opened this issue Jan 30, 2023 · 0 comments · Fixed by #1455
Closed

Drowdown in Application layout header has bigger height #1451

aidamag opened this issue Jan 30, 2023 · 0 comments · Fixed by #1455
Assignees
Labels
bug Something isn't working jira This task is referenced in a story of Jira

Comments

@aidamag
Copy link
Contributor

aidamag commented Jan 30, 2023

Describe the bug
Container DxcApplicationLayout.Header.Dropdown has more height than in the specifications.

To Reproduce

import { DxcApplicationLayout, DxcDropdown } from "@dxc-technology/halstack-react";
import React from "react";

export default function App() {
  const optionsUser = [
    {
      value: 1,
      label: "Test",
    },
    {
      value: 2,
      label: "Test",
    },
  ];

  return (
    <DxcApplicationLayout
    header={
      <DxcApplicationLayout.Header
        content={
          <React.Fragment>
            <DxcApplicationLayout.Header.Dropdown
            label="Header Dropdown"
            options={optionsUser}/>
            <DxcDropdown
            label="Dropdown"
            options={optionsUser}/>
          </React.Fragment>
        }
      ></DxcApplicationLayout.Header>
    }
    >
      <DxcApplicationLayout.Main>Main Content</DxcApplicationLayout.Main>
    </DxcApplicationLayout>
  );
}

First dropdown using DxcApplicationLayout.Header.Dropdown has 44px of height. Meanwhile, a normal dropdown (the second one), it has 40px of height.

Expected behaviour
It should have height: 40px as it is specified in the specifications.

Screenshots
image

image

image

Add labels
dropdown, header, application layout.

@aidamag aidamag added the bug Something isn't working label Jan 30, 2023
@GomezIvann GomezIvann linked a pull request Feb 2, 2023 that will close this issue
5 tasks
@aidamag aidamag added the jira This task is referenced in a story of Jira label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira This task is referenced in a story of Jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants