Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown's menu list update #1455

Merged
merged 7 commits into from Feb 6, 2023
Merged

Dropdown's menu list update #1455

merged 7 commits into from Feb 6, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Feb 2, 2023

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

Dropdown Menu

The adopted solution is:

  • The menu's minimum width will be the maximum option length (min-width: "min-content").
  • If the button is longer than that minimum width, it will increase to match the current width of the button (width: "Npx", being N the width of the button trigger).

Header Dropdown

The dropdown in the Header had a special container for styling, which was overflowing the header's intrinsic height. To fix this, I add a display: flex, which by default always tries to fit the parent element that contains it.

Screenshots

image
image

image

Closes #1438 and #1451

@GomezIvann GomezIvann linked an issue Feb 2, 2023 that may be closed by this pull request
@GomezIvann GomezIvann marked this pull request as ready for review February 2, 2023 12:56
@jsuarezgonz jsuarezgonz self-assigned this Feb 3, 2023
@jsuarezgonz jsuarezgonz merged commit 0a9608a into master Feb 6, 2023
@jsuarezgonz jsuarezgonz deleted the gomezivann-dropdown-update branch February 6, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drowdown in Application layout header has bigger height Dropdown - Menu ( options size fit )
2 participants