Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DxcDropdown adds right padding even when no "arrow" is displayed #402

Closed
pcastanoigle opened this issue Oct 20, 2021 · 1 comment · Fixed by #406
Closed

DxcDropdown adds right padding even when no "arrow" is displayed #402

pcastanoigle opened this issue Oct 20, 2021 · 1 comment · Fixed by #406
Assignees

Comments

@pcastanoigle
Copy link

Describe the bug

The content of the collapsed dropdown is not displayed centered, there is a padding included on the right:

image

image

 displayValue: (          <DxcDropdown   options={options}    onSelectOption={(option) => item.onClickOption(option)}  iconSrc={more_horiz}            caretHidden={true}   theme="dark" ></DxcDropdown>        ),

To Reproduce
See code above.

Expected behavior
Should be displayed centered.

Screenshots
See above
Additional context

Add labels
"@dxc-technology/halstack-react": "^3.3.0",

@aweell
Copy link
Collaborator

aweell commented Oct 20, 2021

Adding to the issue:

  • It seems that the display of the SVG container should be set to none instead of inline-block when the prop caretHidden is set to true.

When I tried to change to display: none; in Developer central the "next" dropdown in the header doesn't display the label correctly. Why are we making a calc() in the label container?

Screen Shot 2021-10-20 at 12 28 47 PM

@GomezIvann GomezIvann self-assigned this Oct 20, 2021
@GomezIvann GomezIvann linked a pull request Oct 21, 2021 that will close this issue
raquelarrojo added a commit that referenced this issue Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants