Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Select listbox now uses Radix UI popover #1114

Merged
merged 12 commits into from Jun 30, 2022

Conversation

GomezIvann
Copy link
Collaborator

Select component is now supported by Radix UI Primitive: Popover. This has some major improvements:

  1. The component now has collision detection. This changes the listbox position based on the current scroll and select positioning to help the user with an always visible listbox.
DXC.React.Components.-.21.June.2022.mp4
  1. Fixes z-index issues with material components. The listbox now appears within a Portal with absolute positioning, so it won't be stucked behind other components such us Dialog, Button, Checkbox or anyone with a high z-index value.
DXC.React.Components.-.21.June.2022.mp4

@GomezIvann GomezIvann linked an issue Jun 21, 2022 that may be closed by this pull request
@aidamag aidamag self-assigned this Jun 27, 2022
@aidamag
Copy link
Contributor

aidamag commented Jun 28, 2022

What about the z-index with the header? Do you see fine that it is not behind the header?

image

@GomezIvann
Copy link
Collaborator Author

GomezIvann commented Jun 28, 2022

What about the z-index with the header? Do you see fine that it is not behind the header?

image

This is not a problem with the z-index, Portals operate a little bit different since they are outside of the regular DOM tree, so they will always appear on top of every part of the layout (unless it is another portal, like the Dialog, there it would a z-index issue).

This cannot be fixed or changed, which I don't think is a bad thing.

@aidamag aidamag merged commit d2c3c1e into master Jun 30, 2022
@aidamag aidamag deleted the gomezivann-select-update branch June 30, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants