Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major] Sidenav Content Style #1122

Merged
merged 71 commits into from
Aug 5, 2022
Merged

[Major] Sidenav Content Style #1122

merged 71 commits into from
Aug 5, 2022

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Jun 22, 2022

Closes #949

Jialecl and others added 21 commits June 2, 2022 12:33
@Jialecl
Sidenav redesign and child components
ecdfa93
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
90111f8 
…eact into jialecl-sidenav-redesign
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
6de6f31 
…eact into jialecl-sidenav-redesign
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
cd40a08 
…eact into jialecl-sidenav-redesign
@Jialecl
typing and ref
652660b
@Jialecl
Merge branch 'jialecl-sidenav-redesign' of https://github.com/dxc-tec…
8824eab 
…hnology/halstack-react into jialecl-sidenav-redesign
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
e807493 
…eact into jialecl-sidenav-redesign
@Jialecl
removed group selected
452c6d4
@Jialecl
Sidenav only accepts title and section as children
94f298e
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
0bae677 
…eact into jialecl-sidenav-redesign
@Jialecl
Updating tests with new changes
6e74908
@Jialecl
Changing example in app
3ad8a57
@Jialecl
removing footer from example
7505aed
@Jialecl
removing one of the examples from app
d5624e8
@raquelarrojo
Merge branch 'master' into jialecl-sidenav-redesign
0aa07f2
@Jialecl
changing sidenav height
bc7cc6e
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
fc60eaf 
…eact into jialecl-sidenav-redesign
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
3e885f0 
…eact into jialecl-sidenav-redesign
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
209dfd8 
…eact into jialecl-sidenav-redesign
@Jialecl
Adapting Sidenav to App layout
58da5c4
@Jialecl
Adding link onClick comment
1458876
@GomezIvann GomezIvann self-requested a review June 22, 2022 11:30
@GomezIvann GomezIvann self-assigned this Jun 22, 2022
GomezIvann
GomezIvann requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@GomezIvann GomezIvann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[DONE] Update /docs examples from Sidenav page:

image

lib/src/sidenav/Sidenav.stories.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/types.ts Show resolved Hide resolved
lib/src/sidenav/types.ts Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Show resolved Hide resolved
@raquelarrojo
Copy link
Collaborator

raquelarrojo commented Jul 13, 2022 •
edited by GomezIvann

[DONE] When an item is selected in the sidenav, there is one moment when the background is not colored. I think that this should not be happening.

Screen.Recording.2022-07-13.at.08.52.14.mov

@marcialfps marcialfps self-assigned this Aug 4, 2022
marcialfps
marcialfps requested changes Aug 4, 2022
View reviewed changes
lib/src/sidenav/types.ts Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.tsx Outdated Show resolved Hide resolved
lib/src/sidenav/Sidenav.stories.tsx Show resolved Hide resolved
marcialfps
marcialfps previously approved these changes Aug 4, 2022
View reviewed changes
@raquelarrojo raquelarrojo self-requested a review August 5, 2022 10:12
@GomezIvann GomezIvann merged commit 2151ae6 into master Aug 5, 2022
@GomezIvann GomezIvann deleted the jialecl-sidenav-redesign branch August 5, 2022 10:12
@GomezIvann GomezIvann linked an issue Sep 5, 2022 that may be closed by this pull request
[Application-layout] Component review #821
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raquelarrojo raquelarrojo raquelarrojo approved these changes

@GomezIvann GomezIvann GomezIvann approved these changes

@marcialfps marcialfps marcialfps left review comments

Assignees

@raquelarrojo raquelarrojo

@marcialfps marcialfps

@GomezIvann GomezIvann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change sidenav content styles [Application-layout] Component review
4 participants
@Jialecl @raquelarrojo @marcialfps @GomezIvann