Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Material from Dialog component #1203

Merged
merged 7 commits into from Sep 6, 2022
Merged

Remove Material from Dialog component #1203

merged 7 commits into from Sep 6, 2022

Conversation

marcialfps
Copy link
Collaborator

@marcialfps marcialfps commented Jul 28, 2022 •
edited

Changes

@marcialfps marcialfps self-assigned this Jul 28, 2022
@marcialfps marcialfps removed their assignment Jul 28, 2022
@aidamag aidamag self-assigned this Aug 5, 2022
aidamag
aidamag reviewed Aug 5, 2022
View reviewed changes
lib/src/dialog/Dialog.tsx Outdated Show resolved Hide resolved
@aidamag
Copy link
Contributor

aidamag commented Aug 5, 2022 •
edited

In some stories, there is a focus on the close icon with an orange color.
image

@marcialfps marcialfps requested a review from aidamag August 9, 2022 10:38
@marcialfps marcialfps merged commit 0cab25c into master Sep 6, 2022
@marcialfps marcialfps deleted the marcialfps-issue-1196 branch September 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidamag aidamag aidamag approved these changes

Assignees

@aidamag aidamag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Material UI dependencies from Dialog
2 participants
@marcialfps @aidamag